SRV record headless #553
Merged
SRV record headless #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswinsuryan
requested review from
mangelajo,
Oats87,
skitt,
tpantelis and
vthapar
as code owners
aswinsuryan
force-pushed
the
srv-record-headless
branch
from
cf3067a to
6adbebb
Compare
Closed
aswinsuryan
force-pushed
the
srv-record-headless
branch
4 times, most recently
from
9259885 to
52d07d2
Compare
mangelajo
reviewed
Jun 9, 2021
There was a problem hiding this comment.
Can I get a more elaborate description of what we are trying to implement exactly and how it should behave?
I was looking at https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#srv-records for the non multi-cluster case but it doesn't match what I see here.
Fixes: submariner-io#526 Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
srv-record-headless
branch
from
4d0d670 to
95c852d
Compare
mangelajo
reviewed
Jun 10, 2021
vthapar
requested changes
Jun 10, 2021
tpantelis
requested changes
Jun 10, 2021
tpantelis
approved these changes
Jun 11, 2021
Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
srv-record-headless
branch
from
85f587b to
a834072
Compare
vthapar
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SRV record support for headless services
Implements the enhancement proposal here: https://github.com/submariner-io/enhancements/blob/devel/lighthouse/srv-records.md
Resolves issue #526